Fix pagination for trade offer lists
This commit is contained in:
parent
3df4b41750
commit
b20ca8a888
5 changed files with 233 additions and 147 deletions
135
trades/views.py
135
trades/views.py
|
|
@ -72,13 +72,13 @@ class TradeOfferAllListView(ListView):
|
|||
model = TradeOffer
|
||||
template_name = "trades/trade_offer_all_list.html"
|
||||
|
||||
|
||||
def get_context_data(self, *, object_list=None, **kwargs):
|
||||
context = super().get_context_data(**kwargs)
|
||||
request = self.request
|
||||
show_closed = request.GET.get("show_closed", "false").lower() == "true"
|
||||
context["show_closed"] = show_closed
|
||||
|
||||
# Build the queryset with our related objects.
|
||||
queryset = (
|
||||
TradeOffer.objects.select_related('initiated_by')
|
||||
.prefetch_related(
|
||||
|
|
@ -96,12 +96,42 @@ class TradeOfferAllListView(ListView):
|
|||
else:
|
||||
queryset = queryset.filter(is_closed=False)
|
||||
|
||||
# On initial load, use the 'offers_page' parameter.
|
||||
offers_page = request.GET.get("offers_page")
|
||||
offers_paginator = Paginator(queryset, 10)
|
||||
context["all_trade_offers_paginated"] = offers_paginator.get_page(offers_page)
|
||||
|
||||
return context
|
||||
|
||||
def render_to_response(self, context, **response_kwargs):
|
||||
# For AJAX requests, return only the paginated fragment.
|
||||
if self.request.headers.get("X-Requested-With") == "XMLHttpRequest":
|
||||
page = self.request.GET.get("page")
|
||||
show_closed = self.request.GET.get("show_closed", "false").lower() == "true"
|
||||
|
||||
queryset = (
|
||||
TradeOffer.objects.select_related('initiated_by')
|
||||
.prefetch_related(
|
||||
'trade_offer_have_cards__card',
|
||||
'trade_offer_want_cards__card',
|
||||
Prefetch(
|
||||
'acceptances',
|
||||
queryset=TradeAcceptance.objects.select_related('accepted_by', 'requested_card', 'offered_card')
|
||||
)
|
||||
)
|
||||
.order_by("-updated_at")
|
||||
)
|
||||
if show_closed:
|
||||
queryset = queryset.filter(is_closed=True)
|
||||
else:
|
||||
queryset = queryset.filter(is_closed=False)
|
||||
paginated_offers = Paginator(queryset, 10).get_page(page)
|
||||
return render(
|
||||
self.request,
|
||||
"trades/_trade_offer_list_paginated.html",
|
||||
{"offers": paginated_offers}
|
||||
)
|
||||
return super().render_to_response(context, **response_kwargs)
|
||||
|
||||
class TradeOfferMyListView(LoginRequiredMixin, ListView):
|
||||
model = TradeOffer # Fallback model; our context data holds separate filtered querysets.
|
||||
template_name = "trades/trade_offer_my_list.html"
|
||||
|
|
@ -125,40 +155,35 @@ class TradeOfferMyListView(LoginRequiredMixin, ListView):
|
|||
.order_by("-updated_at")
|
||||
)
|
||||
|
||||
def get_context_data(self, **kwargs):
|
||||
context = super().get_context_data(**kwargs)
|
||||
request = self.request
|
||||
show_closed = request.GET.get("show_closed", "false").lower() == "true"
|
||||
context["show_closed"] = show_closed
|
||||
|
||||
friend_codes = request.user.friend_codes.all()
|
||||
friend_code_param = request.GET.get("friend_code")
|
||||
def get_selected_friend_code(self):
|
||||
friend_codes = self.request.user.friend_codes.all()
|
||||
friend_code_param = self.request.GET.get("friend_code")
|
||||
if friend_code_param:
|
||||
try:
|
||||
selected_friend_code = friend_codes.get(pk=friend_code_param)
|
||||
except friend_codes.model.DoesNotExist:
|
||||
selected_friend_code = request.user.default_friend_code or friend_codes.first()
|
||||
selected_friend_code = self.request.user.default_friend_code or friend_codes.first()
|
||||
else:
|
||||
selected_friend_code = request.user.default_friend_code or friend_codes.first()
|
||||
selected_friend_code = self.request.user.default_friend_code or friend_codes.first()
|
||||
|
||||
if not selected_friend_code:
|
||||
raise PermissionDenied("You do not have an active friend code associated with your account.")
|
||||
|
||||
context["selected_friend_code"] = selected_friend_code
|
||||
context["friend_codes"] = friend_codes
|
||||
return selected_friend_code
|
||||
|
||||
def get_show_closed(self):
|
||||
return self.request.GET.get("show_closed", "false").lower() == "true"
|
||||
|
||||
def get_my_trade_offers_paginated(self, page_param):
|
||||
selected_friend_code = self.get_selected_friend_code()
|
||||
queryset = self.get_queryset().filter(initiated_by=selected_friend_code)
|
||||
if show_closed:
|
||||
if self.get_show_closed():
|
||||
queryset = queryset.filter(is_closed=True)
|
||||
else:
|
||||
queryset = queryset.filter(is_closed=False)
|
||||
return Paginator(queryset, 10).get_page(page_param)
|
||||
|
||||
offers_page = request.GET.get("offers_page")
|
||||
offers_paginator = Paginator(queryset, 10)
|
||||
context["my_trade_offers_paginated"] = offers_paginator.get_page(offers_page)
|
||||
|
||||
# ----- Trade Acceptances involving the user -----
|
||||
# Update terminal states to include the thanked and rejected states.
|
||||
def get_involved_acceptances(self, selected_friend_code):
|
||||
terminal_states = [
|
||||
TradeAcceptance.AcceptanceState.THANKED_BY_INITIATOR,
|
||||
TradeAcceptance.AcceptanceState.THANKED_BY_ACCEPTOR,
|
||||
|
|
@ -169,34 +194,72 @@ class TradeOfferMyListView(LoginRequiredMixin, ListView):
|
|||
involved_acceptances_qs = TradeAcceptance.objects.filter(
|
||||
Q(trade_offer__initiated_by=selected_friend_code) | Q(accepted_by=selected_friend_code)
|
||||
).order_by("-updated_at")
|
||||
if self.get_show_closed():
|
||||
return involved_acceptances_qs.filter(state__in=terminal_states)
|
||||
return involved_acceptances_qs.exclude(state__in=terminal_states)
|
||||
|
||||
if show_closed:
|
||||
involved_acceptances = involved_acceptances_qs.filter(state__in=terminal_states)
|
||||
else:
|
||||
involved_acceptances = involved_acceptances_qs.exclude(state__in=terminal_states)
|
||||
|
||||
# ----- Split Acceptances into "Waiting for Your Response" and "Other" -----
|
||||
def get_trade_acceptances_waiting_paginated(self, page_param):
|
||||
selected_friend_code = self.get_selected_friend_code()
|
||||
involved_acceptances = self.get_involved_acceptances(selected_friend_code)
|
||||
waiting_acceptances = involved_acceptances.filter(
|
||||
Q(trade_offer__initiated_by=selected_friend_code, state__in=[
|
||||
TradeAcceptance.AcceptanceState.ACCEPTED,
|
||||
TradeAcceptance.AcceptanceState.RECEIVED,
|
||||
]) |
|
||||
Q(accepted_by=selected_friend_code, state__in=[
|
||||
TradeAcceptance.AcceptanceState.SENT
|
||||
])
|
||||
Q(accepted_by=selected_friend_code, state__in=[TradeAcceptance.AcceptanceState.SENT])
|
||||
)
|
||||
other_party_trade_acceptances = involved_acceptances.exclude(pk__in=waiting_acceptances.values("pk"))
|
||||
return Paginator(waiting_acceptances, 10).get_page(page_param)
|
||||
|
||||
def get_other_party_trade_acceptances_paginated(self, page_param):
|
||||
selected_friend_code = self.get_selected_friend_code()
|
||||
involved_acceptances = self.get_involved_acceptances(selected_friend_code)
|
||||
waiting_acceptances = involved_acceptances.filter(
|
||||
Q(trade_offer__initiated_by=selected_friend_code, state__in=[
|
||||
TradeAcceptance.AcceptanceState.ACCEPTED,
|
||||
TradeAcceptance.AcceptanceState.RECEIVED,
|
||||
]) |
|
||||
Q(accepted_by=selected_friend_code, state__in=[TradeAcceptance.AcceptanceState.SENT])
|
||||
)
|
||||
other_acceptances = involved_acceptances.exclude(pk__in=waiting_acceptances.values("pk"))
|
||||
return Paginator(other_acceptances, 10).get_page(page_param)
|
||||
|
||||
def get_context_data(self, **kwargs):
|
||||
context = super().get_context_data(**kwargs)
|
||||
request = self.request
|
||||
show_closed = self.get_show_closed()
|
||||
context["show_closed"] = show_closed
|
||||
|
||||
selected_friend_code = self.get_selected_friend_code()
|
||||
context["selected_friend_code"] = selected_friend_code
|
||||
context["friend_codes"] = request.user.friend_codes.all()
|
||||
|
||||
# Use request params for initial full page load (could be None)
|
||||
offers_page = request.GET.get("offers_page")
|
||||
waiting_page = request.GET.get("waiting_page")
|
||||
other_page = request.GET.get("other_page")
|
||||
waiting_paginator = Paginator(waiting_acceptances, 10)
|
||||
other_party_paginator = Paginator(other_party_trade_acceptances, 10)
|
||||
|
||||
context["trade_acceptances_waiting_paginated"] = waiting_paginator.get_page(waiting_page)
|
||||
context["other_party_trade_acceptances_paginated"] = other_party_paginator.get_page(other_page)
|
||||
context["my_trade_offers_paginated"] = self.get_my_trade_offers_paginated(offers_page)
|
||||
context["trade_acceptances_waiting_paginated"] = self.get_trade_acceptances_waiting_paginated(waiting_page)
|
||||
context["other_party_trade_acceptances_paginated"] = self.get_other_party_trade_acceptances_paginated(other_page)
|
||||
|
||||
return context
|
||||
|
||||
def render_to_response(self, context, **response_kwargs):
|
||||
# For AJAX requests, return only the paginated fragment.
|
||||
if self.request.headers.get("X-Requested-With") == "XMLHttpRequest":
|
||||
ajax_section = self.request.GET.get("ajax_section")
|
||||
page = self.request.GET.get("page")
|
||||
if ajax_section == "my_trade_offers":
|
||||
offers = self.get_my_trade_offers_paginated(page)
|
||||
elif ajax_section == "waiting_acceptances":
|
||||
offers = self.get_trade_acceptances_waiting_paginated(page)
|
||||
elif ajax_section == "other_party_acceptances":
|
||||
offers = self.get_other_party_trade_acceptances_paginated(page)
|
||||
else:
|
||||
# Fallback to my trade offers.
|
||||
offers = self.get_my_trade_offers_paginated(page)
|
||||
return render(self.request, "trades/_trade_offer_list_paginated.html", {"offers": offers})
|
||||
return super().render_to_response(context, **response_kwargs)
|
||||
|
||||
class TradeOfferDeleteView(LoginRequiredMixin, DeleteView):
|
||||
model = TradeOffer
|
||||
success_url = reverse_lazy("trade_offer_list")
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue