use <a> tags for card_badge and trade_offer clickable areas (except for main card_badge row on trade_offers, still uses @click for now because the a tag can't wrap that content for some reason). closes #14

trades/signals.py

@@ -40,7 +40,7 @@ def adjust_qty_for_trade_offer(trade_offer, card, side, delta):
 def update_trade_offer_closed_status(trade_offer):
     """
     Check if both sides of the trade offer meet the quantity requirement.
-    Mark the trade_offer as closed if all cards have qty_accepted
+    Mark the trade_offer as closed if all cards on one side have qty_accepted
     greater than or equal to quantity; otherwise, mark it as open.
     """
     have_complete = not TradeOfferHaveCard.objects.filter(
@@ -107,6 +107,8 @@ def trade_acceptance_email_notification(sender, instance, created, **kwargs):
     #     return
 
     acting_user = instance._actioning_user
+    del instance._actioning_user
+
     state = instance.state
 
     if state == TradeAcceptance.AcceptanceState.ACCEPTED:
@@ -169,9 +171,6 @@ def trade_acceptance_email_notification(sender, instance, created, **kwargs):
         [recipient_user.email],
     )
 
-    # Clean up the temporary attribute.
-    del instance._actioning_user
-
 @receiver(post_save, sender=TradeAcceptance)
 def trade_acceptance_reputation_update(sender, instance, created, **kwargs):
     """